Skip to content

chore: use standard port for cert-var example #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: use standard port for cert-var example #1129

wants to merge 1 commit into from

Conversation

raymondk
Copy link
Contributor

@raymondk raymondk commented Apr 6, 2025

Overview
The cert-var example had the local dev server proxy to the old port.

  • Bindings were not consistent with the code that dfx generate produces in newer versions
  • Variables are passed to match the variables in the binding generation
  • Local dev server proxy defaults to the local replica port

@raymondk raymondk requested a review from a team as a code owner April 6, 2025 13:53
crusso
crusso approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondk @crusso